Make drush optional #711
Make drush optional #711
Conversation
|
I most likely won't have time to help polish out |
|
@oxyc - Godspeed! I'll likely start working on this, as I want to keep working on decoupling things inside the VM a bit more. |
|
@geerlingguy is there anything left to do here except add documentation? |
| @@ -194,6 +194,7 @@ installed_extras: | |||
| - drupalconsole | |||
| # - elasticsearch | |||
| # - java | |||
| # - drush | |||
There was a problem hiding this comment.
We should probably default to the common case where drush is installed globally, right?
Edit: And move this above elasticsearch..
| @@ -32,6 +33,7 @@ env: | |||
| local_config: tests/ubuntu-16-postgresql.config.yml | |||
| config_dir: /var/www/drupalvm/config | |||
| TEST_INSTALLED_EXTRAS: false | |||
| DRUSH_BIN: "${DRUPALVM_DIR}/drupal/vendor/drush/drush/drush" | |||
There was a problem hiding this comment.
With #991 drush is no longer installed in this scenario.
| @@ -215,6 +216,7 @@ extra_packages: | |||
| extra_security_enabled: false | |||
|
|
|||
| drush_version: "master" | |||
| drush_path: "{{ drupal_composer_install_dir }}/vendor/drush/drush/drush" | |||
There was a problem hiding this comment.
This needs documentation for local codebases. If you're not using composer with drush as a dependency the ansible tasks will fail. The user needs to set drush_path: /usr/local/bin/drush.
There was a problem hiding this comment.
@geerlingguy or do you prefer if we add an ansible task to figure out the drush_path? It would work if we used the default drush_path and only override it if drush is not in installed_extras.
There was a problem hiding this comment.
I'd rather add the task to determine the path and use default if it's not installed via Drupal VM.
There was a problem hiding this comment.
My task idea didn't work. If I set the variable it's not possible to override it in config.yml. Any ideas?
| - name: Update drush_path if drush is not available globally. | ||
| set_fact: | ||
| drush_path: "{{ drupal_composer_install_dir }}/vendor/drush/drush/drush" | ||
| when: "'drush' not in installed_extras" |
There was a problem hiding this comment.
Due to variable precedence this will override the role default but can still be overridden in config.yml. I think? I'll test it and make sure a bit later.
There was a problem hiding this comment.
Nevermind, it's not possible to override it.
|
"Always use project specific drush when available" - Thanks! |
|
This is looking good to me. Any other things we need to change? Since it has to be placed into |
|
I think that's it! The only quirk with this is that you cannot override |
|
I like it a lot! |
|
(This will go into a 3.6.0 release). |
Checking how much faster #449 would make the build. Would obviously need a lot more work. Also makefile tests will fail.